Merged
Conversation
Keeping overflow-checks enabled in release does not measurably impact performance so there is no reason to risk hidden overflows by disabling them. Also switch to panic=abort as we do not want unwinding to happen.
`.write()` may only perform a partial write and then returns the number of bytes written. Use `.write_all()` instead which blocks until everything was written.
These are dangerous because they silently truncate.
This relies on a relatively recent compiler feature. Let's not raise the MSRV just to please clippy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End of year, do some cleaning.